Skip to content

West Midlands | May 2026 | Muhammad-Burhan Mustafa | Sprint 2 | Module-Structuring-and-Testing-Data#1443

Open
burhan-mustafa wants to merge 18 commits into
CodeYourFuture:mainfrom
burhan-mustafa:coursework/sprint-2
Open

West Midlands | May 2026 | Muhammad-Burhan Mustafa | Sprint 2 | Module-Structuring-and-Testing-Data#1443
burhan-mustafa wants to merge 18 commits into
CodeYourFuture:mainfrom
burhan-mustafa:coursework/sprint-2

Conversation

@burhan-mustafa

@burhan-mustafa burhan-mustafa commented Jul 2, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

All tasks in sprint 2 completed.

@burhan-mustafa burhan-mustafa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Structuring-And-Testing-Data The name of the module. Core This is a core task and should be completed by all trainees labels Jul 2, 2026
@Liam310 Liam310 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 7, 2026
Comment thread Sprint-2/3-mandatory-implement/1-bmi.js Outdated
Comment thread Sprint-2/3-mandatory-implement/2-cases.js
Comment thread Sprint-2/3-mandatory-implement/3-to-pounds.js Outdated
Comment thread Sprint-2/2-mandatory-debug/2.js
Comment thread Sprint-2/1-key-errors/1.js Outdated

// =============> write your explanation here
// Since the parameter and variable have the same name, decimalNumber, we will get an error as we can not declare a
// variable of the same name with in the functions local scope

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's another problem with the original code?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answered that in the new changes : )

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like you added another explanation for a problem.... in a different task! My question was in reference to the Sprint-2/1-key-errors/1.js problem. As well as the parameter having the same name as a local variable, there's another issue. What is it?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsies! I must have made a mistake out of exhaustion! I have properly answered it in this next commit

@Liam310 Liam310 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 7, 2026
@burhan-mustafa burhan-mustafa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 13, 2026
@Liam310 Liam310 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 13, 2026
@burhan-mustafa burhan-mustafa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core This is a core task and should be completed by all trainees Module-Structuring-And-Testing-Data The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants